[rust/rqd] Fix process cache and timeout feature#2160
[rust/rqd] Fix process cache and timeout feature#2160aoblet wants to merge 2 commits intoAcademySoftwareFoundation:masterfrom
Conversation
Expected format is in microsecond, rust is generating timestamp in second. We conform before sending to the dispatcher
aoblet
requested review from
DiegoTavares,
lithorus and
ramonfigueiredo
as code owners
|
This should fix the pipeline: fe1b1e2 |
| layer_id: self.request.layer_id.clone(), | ||
| num_cores: self.request.num_cores, | ||
| start_time: start_time as i64, | ||
| start_time: (start_time * 1000) as i64, |
There was a problem hiding this comment.
Can you share where you're seeing a problem with this value? Looking at our environment, startime seems to be reported correctly, but I might be looking at a different view.
There was a problem hiding this comment.
frame.getStartTime() returns in seconds instead of microseconds.
Then the condition is always true as long as a timeout is set on the layer.
rust/crates/rqd/src/system/linux.rs
Outdated
| let start = stat.find('(').unwrap(); | ||
| let end = stat.find(')').unwrap(); | ||
| let fields: Vec<&str> = stat[end+2..].split_whitespace().collect(); | ||
| let session_id: u32 = fields[3].parse().unwrap(); |
There was a problem hiding this comment.
It's worth documenting with a comment what's the expected format.
Based on rqmachine.py on the old rqd, there is some variation on the /stat format that we might have to account for:
Stats file can star with these formats:
- 105 name ...
- 105 (name) ...
- 105 (name with space) ...
- 105 (name with) (space and parenthesis) ...
For the first example, with no parenthesis, the code would panic on your unwrap() call.
I think it's worth creating an isolated function to part /stat to allow adding some unit tests to the bottom of this files to ensure every variation is covered.
There was a problem hiding this comment.
See 103274b.
- Keep NSsid logic and fallback on stat file fetching
- Better rust idiom logic
- Refacto to a specific method
Depending on multiple criterias proc/status might not contain NSSid field, they can be: - OS and version - Kernel version - SELinux state - App Armor - OS So instead of parsing proc/status file we revert back to python rqd implementation using proc/stat.
2 participants
Link the Issue(s) this Pull Request is related to.
#2159
#2158
Summarize your change.
Update rust rqd to: